On December 11, 2024 2:36:34 PM Marcel Hamer <marcel.hamer@xxxxxxxxxxxxx>
wrote:
Including the fwil.h header file can lead to a build error:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h: \
In function ‘brcmf_fil_cmd_int_set’:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h:90:9: error: implicit \
declaration of function ‘brcmf_dbg’ [-Werror=implicit-function-declaration]
90 | brcmf_dbg(FIL, "ifidx=%d, cmd=%d, value=%d\n", ifp->ifidx,
cmd, data);
| ^~~~~~~~~
The error is often avoided because the debug.h header file is included
before the fwil.h header file.
This makes sure the header include order is irrelevant by explicitly adding the
debug.h header.
I understand the change, but not sure if it is actually solving anything.
Then again there are plenty of include files including others so...
Acked-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>
Fixes: 31343230abb1 ("wifi: brcmfmac: export firmware interface functions")
Signed-off-by: Marcel Hamer <marcel.hamer@xxxxxxxxxxxxx>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h | 2 ++
1 file changed, 2 insertions(+)
