On Fri, Dec 13, 2024 at 4:05 PM Petr Mladek <pmladek@xxxxxxxx> wrote:
>
> On Fri 2024-12-13 13:46:04, Yafang Shao wrote:
> > Since the task->comm is guaranteed to be NUL-ternimated, we can print it
> > directly. Add a new vsnprintf format specifier "%pTN" to print task comm,
> > where 'p' represents the task Pointer, 'T' stands for Task, and 'N' denots
> > Name. With this abstraction, the user no longer needs to care about
> > retrieving task name.
>
> What is the advantage, please?
The advantage is that it provides the flexibility to modify the comm
representation to meet future requirements. For instance, we could
rename it to "task_name" and increase its size.
>
> Honestly, I believe that the meaning of
>
> printk("%s\n", task->comm);
>
> is much more clear than using a cryptic %pXYZ modifier:
>
> printk("%pTN\n", task);
>
>
> The %pXYZ modifiers makes sense only when the formatting of the printed
> information needs some processing. But this is a plain string.
That makes sense to me.
> IMHO, it is not worth it. In fact, I believe that it is a
> counter productive.
Linus, what are your thoughts?
--
Regards
Yafang
