Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxx> wrote:
> Commit 2461c7d60f9f ("rtlwifi: Update header file") introduced a global
> list of private data structures.
>
> Later on, commit 26634c4b1868 ("rtlwifi Modify existing bits to match
> vendor version 2013.02.07") started adding the private data to that list at
> probe time and added a hook, check_buddy_priv to find the private data from
> a similar device.
>
> However, that function was never used.
>
> Besides, though there is a lock for that list, it is never used. And when
> the probe fails, the private data is never removed from the list. This
> would cause a second probe to access freed memory.
>
> Remove the unused hook, structures and members, which will prevent the
> potential race condition on the list and its corruption during a second
> probe when probe fails.
>
> Fixes: 26634c4b1868 ("rtlwifi Modify existing bits to match vendor version 2013.02.07")
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxx>
Correct wording reported by checkpatch in commit
"wifi: rtlwifi: fix memory leaks and invalid access at probe error path"
during committing.
4 patch(es) applied to rtw-next branch of rtw.git, thanks.
2fdac64c3c35 wifi: rtlwifi: remove unused check_buddy_priv
d8ece6fc3694 wifi: rtlwifi: destroy workqueue at rtl_deinit_core
e7ceefbfd8d4 wifi: rtlwifi: fix memory leaks and invalid access at probe error path
b59b86c5d08b wifi: rtlwifi: pci: wait for firmware loading before releasing memory
---
https://github.com/pkshih/rtw.git
