On 12/6/24 01:43, Johannes Berg wrote:
On Thu, 2024-12-05 at 14:55 -0800, greearb@xxxxxxxxxxxxxxx wrote:
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
This check keeps mtk7996 from loading. If someone thinks
they can get ADHOC to work, let them try it. If the
kernel really needs to restrict some combination, then
it should be done at time user attempts to actually
use that combination, not at driver load.
I disagree, the driver shouldn't advertise non-sense interface
combinations that cannot possibly work correctly.
From the code comment, it looks like it might be possible to get into
a bad configuration if peer ADHOC uses a small beacon time, and if
that also messes up mtk7996 firmware somehow. But also,
it could work just fine if they did not use a small beacon time,
or if firmware magically deals with this somehow with work-arounds
specific to ADHOC (and yet still want normal APs to use 100 or larger
for beacon timer). So 'cannot possibly work correctly'
is a bit of overreach I think.
Hello Felix,
Any suggestions for how to fix this? Disable ADHOC in 7996, or set the beacon_int_min_gcd
to zero to allow it to be any duration?
What is openwrt doing to allow mtk7996 to load?
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
