Jeff Johnson <jeff.johnson@xxxxxxxxxxxxxxxx> writes: > On 12/4/2024 8:32 AM, Kalle Valo wrote: > >> From: Aditya Kumar Singh <quic_adisi@xxxxxxxxxxx> >> >> At present, the mlo_capable_flags in ath12k_base is used to indicate whether >> the chip supports inter (QCN9274) or intra (WCN7850) chip MLO. However, it’s >> possible that the chip supports neither, especially with older firmware >> versions. Additionally, if intra chip MLO is not supported, inter chip MLO will >> also be non-functional. Therefore, having two separate flags for this is >> unnecessary. >> >> Therefore, rename this flag to single_chip_mlo_supp. At the same time convert >> it into a bool data type. Also, get rid of the enums defined earlier. >> >> For the QCN9274 family of chipsets, this will be set only when firmware >> advertises the support during the QMI exchange. >> >> For the WCN7850 family of chipsets, since the event is not supported, >> assumption is made that single chip MLO is supported. >> >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 >> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 >> >> Signed-off-by: Aditya Kumar Singh <quic_adisi@xxxxxxxxxxx> > > Kalle, this patch is missing your SOB. > Please reply with the tag and I'll fix in 'pending' Oh darn, sorry about that. Here it is: Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx> -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
