Hi Issam, kernel test robot noticed the following build warnings: [auto build test WARNING on dfc14664794a4706e0c2186a0c082386e6b14c4d] url: https://github.com/intel-lab-lkp/linux/commits/Issam-Hamdi/wifi-mac80211-fix-mbss-changed-flags-corruption-on-32-bit-systems/20241121-150801 base: dfc14664794a4706e0c2186a0c082386e6b14c4d patch link: https://lore.kernel.org/r/20241118125640.1110502-1-ih%40simonwunderlich.de patch subject: [PATCH v2] wifi: mac80211: fix mbss changed flags corruption on 32 bit systems config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20241126/202411260443.dZKFWC4G-lkp@xxxxxxxxx/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241126/202411260443.dZKFWC4G-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202411260443.dZKFWC4G-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): In file included from net/mac80211/mesh.c:11: In file included from net/mac80211/ieee80211_i.h:16: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:10: In file included from include/linux/mm.h:2213: include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ In file included from net/mac80211/mesh.c:11: In file included from net/mac80211/ieee80211_i.h:16: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 548 | val = __raw_readb(PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ In file included from net/mac80211/mesh.c:11: In file included from net/mac80211/ieee80211_i.h:16: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ In file included from net/mac80211/mesh.c:11: In file included from net/mac80211/ieee80211_i.h:16: In file included from include/linux/if_ether.h:19: In file included from include/linux/skbuff.h:17: In file included from include/linux/bvec.h:10: In file included from include/linux/highmem.h:12: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 585 | __raw_writeb(value, PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ >> net/mac80211/mesh.c:1163:7: warning: address of array 'bits' will always evaluate to 'true' [-Wpointer-bool-conversion] 1163 | if (!bits) | ~^~~~ 8 warnings generated. vim +1163 net/mac80211/mesh.c 2b5e19677592c1 Thomas Pedersen 2013-02-14 1155 2b5e19677592c1 Thomas Pedersen 2013-02-14 1156 void ieee80211_mbss_info_change_notify(struct ieee80211_sub_if_data *sdata, 15ddba5f43114c Anjaneyulu 2023-06-04 1157 u64 changed) 2b5e19677592c1 Thomas Pedersen 2013-02-14 1158 { f81a9dedaff434 Thomas Pedersen 2013-06-13 1159 struct ieee80211_if_mesh *ifmsh = &sdata->u.mesh; f0e1110ae72964 Issam Hamdi 2024-11-18 1160 unsigned long bits[] = { BITMAP_FROM_U64(changed) }; f81a9dedaff434 Thomas Pedersen 2013-06-13 1161 u32 bit; f81a9dedaff434 Thomas Pedersen 2013-06-13 1162 f81a9dedaff434 Thomas Pedersen 2013-06-13 @1163 if (!bits) 2b5e19677592c1 Thomas Pedersen 2013-02-14 1164 return; f81a9dedaff434 Thomas Pedersen 2013-06-13 1165 f81a9dedaff434 Thomas Pedersen 2013-06-13 1166 /* if we race with running work, worst case this work becomes a noop */ f0e1110ae72964 Issam Hamdi 2024-11-18 1167 for_each_set_bit(bit, bits, sizeof(changed) * BITS_PER_BYTE) 6e48ebffc2db54 Felix Fietkau 2023-09-13 1168 set_bit(bit, ifmsh->mbss_changed); f81a9dedaff434 Thomas Pedersen 2013-06-13 1169 set_bit(MESH_WORK_MBSS_CHANGED, &ifmsh->wrkq_flags); 16114496d684a3 Johannes Berg 2023-06-06 1170 wiphy_work_queue(sdata->local->hw.wiphy, &sdata->work); 2b5e19677592c1 Thomas Pedersen 2013-02-14 1171 } 2b5e19677592c1 Thomas Pedersen 2013-02-14 1172 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
