Search Linux Wireless

Re: [PATCH v2 1/2] wifi: cfg80211: define and use wiphy guard

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johannes,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20241121]
[also build test ERROR on linus/master]
[cannot apply to wireless/main v6.12 v6.12-rc7 v6.12-rc6 v6.12]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Johannes-Berg/wifi-mac80211-use-wiphy-guard/20241122-062854
base:   next-20241121
patch link:    https://lore.kernel.org/r/20241121232705.df08bb9e8a9e.I610c9b14f36902e75e1d13f0db29f8bef2298804%40changeid
patch subject: [PATCH v2 1/2] wifi: cfg80211: define and use wiphy guard
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241122/202411220915.PM4S8Hsp-lkp@xxxxxxxxx/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241122/202411220915.PM4S8Hsp-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411220915.PM4S8Hsp-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   In file included from net/wireless/core.c:22:
   In file included from include/linux/etherdevice.h:20:
   In file included from include/linux/if_ether.h:19:
   In file included from include/linux/skbuff.h:17:
   In file included from include/linux/bvec.h:10:
   In file included from include/linux/highmem.h:8:
   In file included from include/linux/cacheflush.h:5:
   In file included from arch/x86/include/asm/cacheflush.h:5:
   In file included from include/linux/mm.h:2223:
   include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     504 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     505 |                            item];
         |                            ~~~~
   include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     511 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     512 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     524 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     525 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
>> net/wireless/core.c:1132:3: error: redefinition of label '__UNIQUE_ID_label1828'
    1132 |                 scoped_guard(wiphy, &rdev->wiphy)
         |                 ^
   include/linux/cleanup.h:339:24: note: expanded from macro 'scoped_guard'
     339 |         __scoped_guard(_name, __UNIQUE_ID(label), args)
         |                               ^
   include/linux/compiler.h:189:29: note: expanded from macro '__UNIQUE_ID'
     189 | #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
         |                             ^
   include/linux/compiler_types.h:84:22: note: expanded from macro '__PASTE'
      84 | #define __PASTE(a,b) ___PASTE(a,b)
         |                      ^
   include/linux/compiler_types.h:83:23: note: expanded from macro '___PASTE'
      83 | #define ___PASTE(a,b) a##b
         |                       ^
   <scratch space>:117:1: note: expanded from here
     117 | __UNIQUE_ID_label1828
         | ^
   net/wireless/core.c:1132:3: note: previous definition is here
   include/linux/cleanup.h:339:24: note: expanded from macro 'scoped_guard'
     339 |         __scoped_guard(_name, __UNIQUE_ID(label), args)
         |                               ^
   include/linux/compiler.h:189:29: note: expanded from macro '__UNIQUE_ID'
     189 | #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
         |                             ^
   include/linux/compiler_types.h:84:22: note: expanded from macro '__PASTE'
      84 | #define __PASTE(a,b) ___PASTE(a,b)
         |                      ^
   include/linux/compiler_types.h:83:23: note: expanded from macro '___PASTE'
      83 | #define ___PASTE(a,b) a##b
         |                       ^
   <scratch space>:117:1: note: expanded from here
     117 | __UNIQUE_ID_label1828
         | ^
>> net/wireless/core.c:1132:3: error: cannot jump from this goto statement to its label
    1132 |                 scoped_guard(wiphy, &rdev->wiphy)
         |                 ^
   include/linux/cleanup.h:339:2: note: expanded from macro 'scoped_guard'
     339 |         __scoped_guard(_name, __UNIQUE_ID(label), args)
         |         ^
   include/linux/cleanup.h:332:10: note: expanded from macro '__scoped_guard'
     332 |              ({ goto _label; }))                                        \
         |                 ^
   net/wireless/core.c:1132:3: note: jump bypasses initialization of variable with __attribute__((cleanup))
   include/linux/cleanup.h:339:2: note: expanded from macro 'scoped_guard'
     339 |         __scoped_guard(_name, __UNIQUE_ID(label), args)
         |         ^
   include/linux/cleanup.h:330:20: note: expanded from macro '__scoped_guard'
     330 |         for (CLASS(_name, scope)(args);                                 \
         |                           ^
   net/wireless/core.c:1130:29: note: jump enters a statement expression
    1130 |         wait_event(rdev->dev_wait, ({
         |                                    ^
   4 warnings and 2 errors generated.


vim +/__UNIQUE_ID_label1828 +1132 net/wireless/core.c

  1125	
  1126	void wiphy_unregister(struct wiphy *wiphy)
  1127	{
  1128		struct cfg80211_registered_device *rdev = wiphy_to_rdev(wiphy);
  1129	
  1130		wait_event(rdev->dev_wait, ({
  1131			int __count;
> 1132			scoped_guard(wiphy, &rdev->wiphy)
  1133				__count = rdev->opencount;
  1134			__count == 0; }));
  1135	
  1136		if (rdev->wiphy.rfkill)
  1137			rfkill_unregister(rdev->wiphy.rfkill);
  1138	
  1139		rtnl_lock();
  1140		wiphy_lock(&rdev->wiphy);
  1141		nl80211_notify_wiphy(rdev, NL80211_CMD_DEL_WIPHY);
  1142		rdev->wiphy.registered = false;
  1143	
  1144		WARN_ON(!list_empty(&rdev->wiphy.wdev_list));
  1145	
  1146		/*
  1147		 * First remove the hardware from everywhere, this makes
  1148		 * it impossible to find from userspace.
  1149		 */
  1150		debugfs_remove_recursive(rdev->wiphy.debugfsdir);
  1151		list_del_rcu(&rdev->list);
  1152		synchronize_rcu();
  1153	
  1154		/*
  1155		 * If this device got a regulatory hint tell core its
  1156		 * free to listen now to a new shiny device regulatory hint
  1157		 */
  1158		wiphy_regulatory_deregister(wiphy);
  1159	
  1160		cfg80211_rdev_list_generation++;
  1161		device_del(&rdev->wiphy.dev);
  1162	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux