On Thu, 2024-11-21 at 18:35 +0100, Paolo Perego wrote: > On Thu, Nov 21, 2024 at 06:28:14PM GMT, Johannes Berg wrote: > > On Thu, 2024-11-21 at 18:02 +0100, Paolo Perego wrote: > > > This patch fixes a dereference before null check issue discovered by > > > Coverity (CID 1601547) > > > > > > > This was reported before by smatch too, and Emmanuel just made a patch > > to simply remove the NULL checks, because the pointers are statically > > known to be not NULL. So it's not really an issue other than > > style/checkers/... anyway :) > Oops, I'm so sorry this was already fixed. In Coverity dashboard the > item seemed to be still open. Oh it wasn't fixed yet, the patch isn't anywhere near the trees. But it's also not very important, so I doubt we'll handle it urgently. > Apart from that, did I followed the right steps? Was my submission good > enough? (I'm new to kernel hacking and I'm still in the learning phase) > Well, should've had the right subject prefix, as "wifi: iwlwifi:" but other than that, I guess? Arguably, you also shouldn't have had the = 0 in the code, since it got unconditionally assigned anyway. And, if you're going to continue looking at Coverity reports, I'd suggest to dig a bit deeper. We're not here to fix reports from Coverity after all, we should fix _bugs_, and tools will get things wrong :) johannes
