Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes: > Kalle Valo <kvalo@xxxxxxxxxx> wrote: > >> Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes: >> >> > From: Zong-Zhe Yang <kevin_yang@xxxxxxxxxxx> >> > >> > After FW v0.35.46.0, for AP mode, RTL8922A FW supports a new FW feature, >> > called NOTIFY_AP_INFO, to notify driver information related to AP mode. >> > And, one function of it is to monitor PS states of remote stations. Once >> > one of them changes, FW will send a C2H event to tell driver. With this >> > FW feature, we can declare AP_LINK_PS. >> > >> > For now, driver still needs to determine if a frame is ps-poll or U-APSD >> > trigger. So, add the corresponding RX handling in driver, which activates >> > only when at least one AP is running. >> > >> > Signed-off-by: Zong-Zhe Yang <kevin_yang@xxxxxxxxxxx> >> > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> >> >> [...] >> >> > +// CLASS 36 - SoftAP >> >> In wireless we prefer '/* */'. >> > > The checkpatch is changed to allow this style by default, so I didn't catch > the warning. Add option "--ignore C99_COMMENT_TOLERANCE" to my local script. Oh, didn't know that. We should then add that to our ath12k-check script as well. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches