On 12/11/2024 07:45, Nemanov, Michael wrote: > On 11/8/2024 2:02 PM, Krzysztof Kozlowski wrote: >> On Thu, Nov 07, 2024 at 02:51:53PM +0200, Michael Nemanov wrote: >>> Add device-tree bindings for the CC33xx family. >>> >>> Signed-off-by: Michael Nemanov <michael.nemanov@xxxxxx> >>> --- >>> .../bindings/net/wireless/ti,cc33xx.yaml | 59 +++++++++++++++++++ >>> 1 file changed, 59 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml >>> >> >> <form letter> >> This is a friendly reminder during the review process. >> >> It seems my or other reviewer's previous comments were not fully >> addressed. Maybe the feedback got lost between the quotes, maybe you >> just forgot to apply it. Please go back to the previous discussion and >> either implement all requested changes or keep discussing them. >> >> Thank you. >> </form letter> >> >> Best regards, >> Krzysztof >> > > Are you referring to > >> diff --git a/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml b/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml > > ... > >> + >> +properties: >> + $nodename: >> + pattern: "^wifi@2" > > ? > > If so, I replied here > https://lore.kernel.org/linux-wireless/8024aa1c-5bd1-40d8-b0c3-14b5fcd992e2@xxxxxx/#t > But if you don't think it's worthwhile I'll remove it. I asked you to remove it. It's not correct, not needed, not beneficial at all. It is actually harmful because limits re-use. dtc already checks this. Best regards, Krzysztof
