On 11/14/2024 7:34 PM, Kalle Valo wrote:
> Baochen Qiang <quic_bqiang@xxxxxxxxxxx> writes:
>
>> On 11/13/2024 7:14 PM, Kalle Valo wrote:
>>> Baochen Qiang <quic_bqiang@xxxxxxxxxxx> writes:
>>>
>>>> Commit b488c766442f ("ath11k: report rssi of each chain to mac80211 for QCA6390/WCN6855")
>>>> and commit c3b39553fc77 ("ath11k: add signal report to mac80211 for QCA6390 and WCN6855")
>>>> call debugfs functions in mac ops. Those functions are no-ops if CONFIG_ATH11K_DEBUGFS is
>>>> not enabled, thus cause wrong status reported.
>>>
>>> What do you mean exactly with wrong status reported?
>>
>> ah, thanks for pointing that. actually no wrong values reported, since
>> we are not even reporting anything in that case. will be accurate.
>>
>>>
>>> mac.c is quite large already, making it even bigger is something I would
>>> like to avoid.
>>
>> then can you suggest any other place?
>
> I first need to understand the issue we are fixing. Is it ath11k does
> not report rssi and signal via ath11k_mac_op_sta_statistics() when
> CONFIG_ATH11K_DEBUGFS is disabled?
Yes, Kalle. If CONFIG_ATH11K_DEBUGFS is disabled, ath11k_debugfs_get_fw_stats() is a no-ops, so no WMI command sent to firmware, thus no WMI event and therefore ath11k does not report them.
>
