"Alf Marius" <post@xxxxxxxxxxxxx> writes: > Good evening folks :) > > [Andrey Batyiev] >> Hello everyone, >> I've only tested it on my 3945. I have no equipment to test it on 4965, sorry. > > Yes the commit message says "Tested on iwl3945 only." > ..which I did find a bit strange. Is it normal to deploy code to the mainline > that is untested? Why was this also applied to 4965? > > I'm just asking questions here, as I have no direct knownledge of C or > kernel driver programming. I've 20 yrs of web-dev experience though > and know from experience that shipping untested code is a bad idea. > > Anyway, not trying to point fingers here! Just curious to find those who > wrote the actual code, maybe get some info on why this was added > and if it is really important. If not, maybe a revert is in order > > Regarding testing, I obviously have a laptop with the 4965 card and > I'm more than willing to test stuff out if needed. I sent a revert to fix this: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git/commit/?id=11597043d74809daf5d14256b96d6781749b3f82 If all goes well this should be in v6.13-rc1. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
