Hello Dan,
On Tue, 2024-11-12 at 12:44 +0300, Dan Carpenter wrote:
> Hello Emmanuel Grumbach,
>
> Commit e8bb19c1d590 ("wifi: iwlwifi: support fast resume") from Jun
> 18, 2024 (linux-next), leads to the following Smatch static checker
> warning:
>
> drivers/net/wireless/intel/iwlwifi/mvm/d3.c:3121
> iwl_mvm_check_rt_status()
> error: uninitialized symbol 'err_id'.
>
> drivers/net/wireless/intel/iwlwifi/mvm/d3.c
> 3112 static bool iwl_mvm_check_rt_status(struct iwl_mvm *mvm,
> 3113 struct ieee80211_vif
> *vif)
> 3114 {
> 3115 u32 err_id;
> 3116
> 3117 /* check for lmac1 error */
> 3118 if (iwl_fwrt_read_err_table(mvm->trans,
> 3119 mvm->trans-
> >dbg.lmac_error_event_table[0],
> 3120 &err_id)) {
>
> iwl_fwrt_read_err_table() returns true on failure (meaning that we
> weren't able
> to read the error table so maybe that the two errors cancel each
> other (double
> negative) so there wasn't an error?) Anyway if
> iwl_trans_read_mem_bytes() fails
> then "err_id" is not initialized.
Thanks for this report.
I'll send a patch internally to fix this.
>
> --> 3121 if (err_id == RF_KILL_INDICATOR_FOR_WOWLAN
> && vif) {
> 3122 struct cfg80211_wowlan_wakeup wakeup
> = {
> 3123 .rfkill_release = true,
> 3124 };
> 3125 ieee80211_report_wowlan_wakeup(vif,
> &wakeup,
> 3126
> GFP_KERNEL);
> 3127 }
> 3128 return true;
> 3129 }
> 3130
