Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> wrote: > The fixed patch introduced an additional condition to enter the scope > where the 'root' device_node is released (!settings->board_type, > currently 'err'), which avoid decrementing the refcount with a call to > of_node_put() if that second condition is not satisfied. > > Move the call to of_node_put() to the point where 'root' is no longer > required to avoid leaking the resource if err is not zero. > > Cc: stable@xxxxxxxxxxxxxxx > Fixes: 7682de8b3351 ("wifi: brcmfmac: of: Fetch Apple properties") > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> Patch applied to wireless-next.git, thanks. 2e19a3b590eb wifi: brcmfmac: release 'root' node in all execution paths -- https://patchwork.kernel.org/project/linux-wireless/patch/20241030-brcmfmac-of-cleanup-v1-1-0b90eefb4279@xxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches