Search Linux Wireless

Re: [PATCH v5 05/17] wifi: cc33xx: Add cmd.c, cmd.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



…
> Similar to wlcore, all commands eventually reach
> __cc33xx_cmd_send which fills a generic command
> header and send the buffer via the IO abstraction layer.
…

You may occasionally put more than 56 characters into text lines
for an improved change description.


…
> +++ b/drivers/net/wireless/ti/cc33xx/cmd.c
> @@ -0,0 +1,1920 @@
…
> +int cc33xx_set_link(struct cc33xx *cc, struct cc33xx_vif *wlvif, u8 link)
> +{
> +	unsigned long flags;
> +
> +	/* these bits are used by op_tx */
> +	spin_lock_irqsave(&cc->cc_lock, flags);
> +	__set_bit(link, cc->links_map);
> +	__set_bit(link, wlvif->links_map);
> +	spin_unlock_irqrestore(&cc->cc_lock, flags);
…

Under which circumstances would you become interested to apply a macro call
like “scoped_guard(spinlock_irqsave, &cc->cc_lock)”?
https://elixir.bootlin.com/linux/v6.12-rc6/source/include/linux/spinlock.h#L572

Regards,
Markus





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux