First, iw patches don't need "wifi:" prefix :) > MLD Capability: 0x44 > Max Number of Simultaneous Links: 4 I think we should print the other MLD capabilities too? > hw_idx 0 channel list: > 1 2 3 4 5 6 7 8 9 10 11 12 13 14 > hw_idx 1 channel list: > 36 40 44 48 52 56 60 64 100 104 108 112 116 120 124 128 > 132 136 140 144 149 153 157 161 165 169 173 177 > hw_idx 2 channel list: > 1 2 5 9 13 17 21 25 29 33 37 41 45 49 53 57 61 65 69 73 > 77 81 85 89 93 97 101 105 109 113 117 121 125 129 133 > 137 141 145 149 153 157 161 165 169 173 177 181 185 189 > 193 197 201 205 209 213 217 221 225 229 233 I don't believe this exists upstream, so not sure why you included it in the example. > if (tb_msg[NL80211_ATTR_MAX_AP_ASSOC_STA]) > printf("\tMaximum associated stations in AP mode: %u\n", > nla_get_u32(tb_msg[NL80211_ATTR_MAX_AP_ASSOC_STA])); > + if (tb_msg[NL80211_ATTR_IFTYPE_EXT_CAPA]) { blank line before that would be nice > + int rem_ext = 0; > + struct nlattr *tb1[NL80211_ATTR_MAX + 1]; > + struct nlattr *ext_attr; > + __u8 max_simul_links; > + __u16 mld_cap; > + > + nla_for_each_nested(ext_attr, tb_msg[NL80211_ATTR_IFTYPE_EXT_CAPA], rem_ext) { > + nla_parse(tb1, NL80211_ATTR_MAX, nla_data(ext_attr), > + nla_len(ext_attr), NULL); there's some bad indentation here and later > + } > + And here you didn't need an extra blank line. johannes