Sven Eckelmann <se@xxxxxxxxxxxxxxxxxx> writes: > On Wednesday, 6 November 2024 10:04:39 CET Issam Hamdi wrote: > [...] >> This patch originally developed by "Simon Wunderlich <simon.wunderlich@xxxxxxxxxxxxx>" >> and "Sven Eckelmann <sven.eckelmann@xxxxxxxxxxxxx>" > > Am I the only person which finds this style of adding information about "Co- > authors" weird? No, you are not. I also find it weird. > [...] >> Signed-off-by: Simon Wunderlich <sw@xxxxxxxxxxxxxxxxxx> >> Signed-off-by: Sven Eckelmann <se@xxxxxxxxxxxxxxxxxx> >> Signed-off-by: Issam Hamdi <ih@xxxxxxxxxxxxxxxxxx> >> --- >> v2: change the "Co-developed-by" to "Signed-off-by", remove the dependency > > I think Kalle meant that "Co-developed-by" should be followed by a > "Signed-off-by" - not that "Co-developed-by" should be removed. Correct, to my understanding having both c-d-b and s-o-b is the preferred format. >> on CONFIG_ATH9K_DEBUGFS and add more information in the commit description > > And please don't reply to the old thread when sending a new patchset - this > becomes really unreadable after a while. You can simply use the method which > b4 uses and just reference the old thread in your mail. Something like: > > Changes in v2: > - change the "Co-developed-by" to "Signed-off-by" > - remove the dependency on CONFIG_ATH9K_DEBUGFS > - add more information in the commit description > - Link to v1: https://lore.kernel.org/r/20241104171627.3789199-1-ih@xxxxxxxxxxxxxxxxxx Yes, this style is very much recommended. Having links to older versions helps reviewers. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
