Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> writes: > On 11/1/2024 8:16 AM, Kalle Valo wrote: > >> From: Kalle Valo <quic_kvalo@xxxxxxxxxxx> >> >> Here we continue to refactor mac.c to support multiple links and extend peer >> assoc WMI command to support MLO. >> >> Please review. >> >> v2: >> >> * patch 1: use err_vdev_del >> >> * patch 2: ath12k_mac_mlo_get_vdev_args(): switch >> wiphy_dereference() >> >> * patch 2: use struct ath12k_wmi_mac_addr_params instead adding struct wmi_mac_addr >> >> * patch 3: ath12k_mac_station_post_remove(): assign >> ahsta->links_map before rcu_assign_pointer() >> >> * patch 3: ath12k_mac_station_unauthorize(): fi* confusing comment about __sta_info_destroy_part2() >> >> * patch 4: debugfs.c: copyright year >> >> * patch 5: ath12k_peer_mlo_create(): remove parenthesis from the >> warning message >> >> * patch 5: ATH12K_ML_PEER_ID_VALID: move to peer.h and rename to ATH12K_PEER_ML_ID_VALID >> >> * patch 5: rename struct ath12k_peer::ml_peer_id to peer_id >> >> * patch 5: use ath12k_peer_ml_*() naming style in peer.c >> >> * patch 7: improve commit message a bit >> >> * patch 7: struct wmi_peer_assoc_mlo_partner_info: add _params to name >> >> v1: https://patchwork.kernel.org/project/linux-wireless/cover/20241023133004.2253830-1-kvalo@xxxxxxxxxx/ >> >> Kalle Valo (2): >> wifi: ath12k: ath12k_mac_vdev_create(): use goto for error handling >> wifi: ath12k: introduce ath12k_hw_warn() >> >> Sriram R (6): >> wifi: ath12k: MLO vdev bringup changes >> wifi: ath12k: Refactor sta state machine >> wifi: ath12k: Add helpers for multi link peer creation and deletion >> wifi: ath12k: add multi-link flag in peer create command >> wifi: ath12k: add helper to find multi-link station >> wifi: ath12k: Add MLO peer assoc command support >> >> drivers/net/wireless/ath/ath12k/core.h | 25 ++ >> drivers/net/wireless/ath/ath12k/debug.c | 6 +- >> drivers/net/wireless/ath/ath12k/debug.h | 5 +- >> drivers/net/wireless/ath/ath12k/mac.c | 504 +++++++++++++++++++----- >> drivers/net/wireless/ath/ath12k/peer.c | 115 ++++++ >> drivers/net/wireless/ath/ath12k/peer.h | 12 + >> drivers/net/wireless/ath/ath12k/wmi.c | 191 ++++++++- >> drivers/net/wireless/ath/ath12k/wmi.h | 115 ++++++ >> 8 files changed, 848 insertions(+), 125 deletions(-) >> >> >> base-commit: fa934bf3e0a825ee09f035c6580af513187d59a2 > > with this series I see a new warning with gcc: > drivers/net/wireless/ath/ath12k/mac.c: In function 'ath12k_bss_assoc': > drivers/net/wireless/ath/ath12k/mac.c:3080:1: warning: the frame size > of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=] What GCC version are you using and can you privately share your .config? I'm guessing it's coming from peer_arg which was already in ath12k_bss_assoc() before this patchset: struct ath12k_wmi_peer_assoc_arg peer_arg; And indeed it's a large struct, we shouldn't allocate that from the stack. > we should clean this up with a subsequent patch Agreed. > I'm taking the current series into 'pending' Thanks. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
