Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> writes: > On 10/23/2024 6:30 AM, Kalle Valo wrote: > >> --- a/drivers/net/wireless/ath/ath12k/dp.h >> +++ b/drivers/net/wireless/ath/ath12k/dp.h >> @@ -1796,6 +1796,8 @@ static inline void ath12k_dp_get_mac_addr(u32 addr_l32, u16 addr_h16, u8 *addr) >> memcpy(addr + 4, &addr_h16, ETH_ALEN - 4); >> } >> >> +#define ATH12K_ML_PEER_ID_VALID BIT(13) >> + > > this seems to be randomly placed without any context Yeah, it is. I'll try to find a better place for it. >> @@ -87,6 +101,9 @@ struct ath12k_peer *ath12k_peer_find_by_id(struct ath12k_base *ab, >> >> lockdep_assert_held(&ab->base_lock); >> >> + if (peer_id & ATH12K_ML_PEER_ID_VALID) > > where is code that sets the bit? That will come later in patch 'wifi: ath12k: Add support for HTT MLO peer map and unmap event'. > does other code elsewhere need to mask this bit off to have the "true" peer_id? I'll investigate this. > the commit text for this patch seems to need a lot more description Will fix. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
