Kang Yang <quic_kangyang@xxxxxxxxxxx> writes: > On 10/21/2024 4:46 PM, Kalle Valo wrote: >> Kang Yang <quic_kangyang@xxxxxxxxxxx> writes: >> >>> ath12k_mac_monitor_vdev_create() will set NSS and TX power for monitor >>> vdev. But this is not needed for monitor vdev. >>> >>> So delete them. >>> >>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 >>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 >>> >>> Signed-off-by: Kang Yang <quic_kangyang@xxxxxxxxxxx> >> Does this fix any known issues? Or is just cleanup? > > Clean up Ok, please always mention this in the commit message. In essence you need to answer to the question 'why are we doing this?'. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
