On Fri, 2024-10-25 at 10:51 +0200, Johannes Berg wrote: > > > > + link_iter = > > + rcu_dereference(iter->link[link_id_iter]); > > + if (!link_iter) > > + continue; > > + /* Check if any of link of iterator sdata > > + * belongs to same mbssid group as the tx link > > + */ > > + if (link_iter->conf->mbssid_tx_bss != > > + vif->link_conf[link_id]) > > + continue; > > + > > + wiphy_work_queue(iter->local->hw.wiphy, > > + &link_iter->csa.finalize_work); > > This really got indented a bit too far anyway though - hardly readable > at all. Please refactor. I feel like maybe I should say also: Remember that the _primary_ target audience for your code should be the _human_ reading it (including yourself a year from now). johannes