Hi Remi, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Remi-Pommarel/wifi-ath10k-Implement-ieee80211-flush_sta-callback/20241022-172038 base: https://git.kernel.org/pub/scm/linux/kernel/git/ath/ath.git ath-next patch link: https://lore.kernel.org/r/0f55986ebe34f2b5aa4ccbcb0bed445324099fbd.1729586267.git.repk%40triplefau.lt patch subject: [PATCH v2 2/2] wifi: ath10k: Flush only requested txq in ath10k_flush() config: parisc-randconfig-r071-20241024 (https://download.01.org/0day-ci/archive/20241025/202410251152.A5axJliR-lkp@xxxxxxxxx/config) compiler: hppa-linux-gcc (GCC) 14.1.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> | Closes: https://lore.kernel.org/r/202410251152.A5axJliR-lkp@xxxxxxxxx/ New smatch warnings: drivers/net/wireless/ath/ath10k/mac.c:8076 _ath10k_mac_wait_tx_complete() error: uninitialized symbol 'empty'. vim +/empty +8076 drivers/net/wireless/ath/ath10k/mac.c c4f7022f0ef0aa Remi Pommarel 2024-10-22 8062 static void _ath10k_mac_wait_tx_complete(struct ath10k *ar, c4f7022f0ef0aa Remi Pommarel 2024-10-22 8063 unsigned long queues) 5e3dd157d7e70f Kalle Valo 2013-06-12 8064 { affd321733eebc Michal Kazior 2013-07-16 8065 bool skip; d4298a3a8c92a1 Nicholas Mc Guire 2015-06-15 8066 long time_left; c4f7022f0ef0aa Remi Pommarel 2024-10-22 8067 unsigned int q; 5e3dd157d7e70f Kalle Valo 2013-06-12 8068 5e3dd157d7e70f Kalle Valo 2013-06-12 8069 /* mac80211 doesn't care if we really xmit queued frames or not d6dfe25c8bb200 Marcin Rokicki 2017-02-20 8070 * we'll collect those frames either way if we stop/delete vdevs d6dfe25c8bb200 Marcin Rokicki 2017-02-20 8071 */ 548db54cc1890b Michal Kazior 2013-07-05 8072 affd321733eebc Michal Kazior 2013-07-16 8073 if (ar->state == ATH10K_STATE_WEDGED) 828853ac58265c Wen Gong 2018-08-28 8074 return; affd321733eebc Michal Kazior 2013-07-16 8075 d4298a3a8c92a1 Nicholas Mc Guire 2015-06-15 @8076 time_left = wait_event_timeout(ar->htt.empty_tx_wq, ({ 5e3dd157d7e70f Kalle Valo 2013-06-12 8077 bool empty; affd321733eebc Michal Kazior 2013-07-16 8078 edb8236df4d042 Michal Kazior 2013-07-05 8079 spin_lock_bh(&ar->htt.tx_lock); c4f7022f0ef0aa Remi Pommarel 2024-10-22 8080 for_each_set_bit(q, &queues, ar->hw->queues) { Smatch is concerned that there might not be any set bits. (You know that the compiler is automatically going to ininitialize empty to false so it costs nothing to initialize it to false explicitly and silence this warning). c4f7022f0ef0aa Remi Pommarel 2024-10-22 8081 empty = (ar->htt.num_pending_per_queue[q] == 0); c4f7022f0ef0aa Remi Pommarel 2024-10-22 8082 if (!empty) c4f7022f0ef0aa Remi Pommarel 2024-10-22 8083 break; c4f7022f0ef0aa Remi Pommarel 2024-10-22 8084 } edb8236df4d042 Michal Kazior 2013-07-05 8085 spin_unlock_bh(&ar->htt.tx_lock); affd321733eebc Michal Kazior 2013-07-16 8086 7962b0d898accd Michal Kazior 2014-10-28 8087 skip = (ar->state == ATH10K_STATE_WEDGED) || 7962b0d898accd Michal Kazior 2014-10-28 8088 test_bit(ATH10K_FLAG_CRASH_FLUSH, 7962b0d898accd Michal Kazior 2014-10-28 8089 &ar->dev_flags); affd321733eebc Michal Kazior 2013-07-16 8090 affd321733eebc Michal Kazior 2013-07-16 8091 (empty || skip); 5e3dd157d7e70f Kalle Valo 2013-06-12 8092 }), ATH10K_FLUSH_TIMEOUT_HZ); affd321733eebc Michal Kazior 2013-07-16 8093 d4298a3a8c92a1 Nicholas Mc Guire 2015-06-15 8094 if (time_left == 0 || skip) d4298a3a8c92a1 Nicholas Mc Guire 2015-06-15 8095 ath10k_warn(ar, "failed to flush transmit queue (skip %i ar-state %i): %ld\n", d4298a3a8c92a1 Nicholas Mc Guire 2015-06-15 8096 skip, ar->state, time_left); 828853ac58265c Wen Gong 2018-08-28 8097 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
