On Thu, 2024-10-24 at 16:48 +0200, Sabrina Dubroca wrote: > > If nla_get_*_default was a macro (generating an "attr ? getter : > default" expression) you wouldn't have that problem I think, Hmm. Perhaps. In the conditional operator (?:) they're subject to integer promotion though, I wonder if that could cause some subtle issue too especially if nla_get_u*() is used with signed variables? > but you > couldn't nicely generate all the helpers with MAKE_NLA_GET_DEFAULT > anymore. Right, that too. I think it's probably better to just review them, and only commit the obvious ones originally? johannes
