On 10/22/2024 5:57 PM, Dmitry Baryshkov wrote:
On Tue, Oct 01, 2024 at 11:30:52AM +0800, Miaoqing Pan wrote:
QCA6698AQ uses different firmware/bdf/regdb with existing WCN6855
firmware, which is customized for IoE platforms. And the 'pci-device-id +
soc-hw-version + soc-hw-sub-version' may not be enough to identify the
correct firmware directory path.
Why is it so? What makes it so different from the existing platforms
that you can not use WCN6855 firmware?
Just as I said, a new customized firmware for IoE devices.
The device tree allows "firmware-name" to define the firmware path,
wifi@c000000 {
You are describing platform node, while the commit message talks about
the PCIe devices. Could you please clarify, whether it is a PCIe device
or an AHB device?
PCIe device. The change is for sa8775p/qcs8300 those non-AHB boards.
firmware-name = "QCA6698AQ";
Could we please follow the approach that has been defined in the commit
5abf259772df ("wifi: ath10k: support board-specific firmware
overrides")? In other words, instead of creating another directory under
ath11k, create a subdir under the WCN6855/hwN.M/ which contains your
device-specific data.
Sure, thanks, will update.
status = "okay";
};
Tested-on: QCA6698AQ hw2.1 PCI WLAN.HSP.1.1-04402-QCAHSPSWPL_V1_V2_SILICONZ_IOE-1
Signed-off-by: Miaoqing Pan <quic_miaoqing@xxxxxxxxxxx>
P.S. please CC linux-arm-msm for future respins of this series or for
all other submissions that concern board-specific DT data on MSM
platforms.
ok.
---
drivers/net/wireless/ath/ath11k/core.c | 12 ++++++++++++
drivers/net/wireless/ath/ath11k/core.h | 11 +++--------
2 files changed, 15 insertions(+), 8 deletions(-)
