Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote:
> The type of tsf arithmetic is
> u64 += u16 * int;
>
> When (u16 * int) is larger than 0x7FFFFFFF, the value casting to u64 with
> sign-extension will become all 1 in upper 32 bits part.
>
> To meet the case, u16 value should be larger than 20491
> (0x7FFFFFFF / 104800). Fortunately the meaning of 20491 is delay time of
> WoWLAN net detection in unit of second, so 20491 seconds (5.7 hours)
> might not a real case we can meet.
>
> Addresses-Coverity-ID: 1620910 ("Unintended sign extension")
>
> Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
6 patch(es) applied to rtw-next branch of rtw.git, thanks.
5af57c4f9937 wifi: rtw89: wow: cast nd_config->delay to u64 in tsf arithmetic
778e2478d195 wifi: rtw89: pci: use 'int' as return type of error code in poll_{tx,rx}dma_ch_idle()
66595e319886 wifi: rtw89: 8851b: use 'int' as return type of error code pwr_{on,off}_func()
50e9febff35f wifi: rtw89: 8852b: use 'int' as return type of error code pwr_{on,off}_func()
c72c54fd96d0 wifi: rtw89: 8852bt: use 'int' as return type of error code pwr_{on,off}_func()
74432751ff63 wifi: rtw89: 8852c: use 'int' as return type of error code pwr_{on,off}_func()
---
https://github.com/pkshih/rtw.git
