On 18/10/2024 09:41, Ping-Ke Shih wrote:
> Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote:
>> diff --git a/drivers/net/wireless/realtek/rtw88/main.h b/drivers/net/wireless/realtek/rtw88/main.h
>> index ef82e60d5c19..072d09a7d313 100644
>> --- a/drivers/net/wireless/realtek/rtw88/main.h
>> +++ b/drivers/net/wireless/realtek/rtw88/main.h
>> @@ -1100,16 +1100,19 @@ struct rtw_rfe_def {
>> const struct rtw_table *phy_pg_tbl;
>> const struct rtw_table *txpwr_lmt_tbl;
>> const struct rtw_table *agc_btg_tbl;
>> + const struct rtw_pwr_track_tbl *pwr_track_tbl;
>> };
>>
>> -#define RTW_DEF_RFE(chip, bb_pg, pwrlmt) { \
>> +#define RTW_DEF_RFE(chip, bb_pg, pwrlmt, track) { \
>> .phy_pg_tbl = &rtw ## chip ## _bb_pg_type ## bb_pg ## _tbl, \
>> .txpwr_lmt_tbl = &rtw ## chip ## _txpwr_lmt_type ## pwrlmt ## _tbl, \
>> + .pwr_track_tbl = &rtw ## chip ## _pwr_track_type ## track ## _tbl, \
>> }
>>
>> -#define RTW_DEF_RFE_EXT(chip, bb_pg, pwrlmt, btg) { \
>> +#define RTW_DEF_RFE_EXT(chip, bb_pg, pwrlmt, track, btg) { \
>
> Why not keep the same order of struct declaration?
>
> I guess you want first three arguments of RTW_DEF_RFE() and RTW_DEF_RFE_EXT()
> are the same, right?
Yes.
> Move ' pwr_track_tbl' entry in struct upward one line as
> below order?
>
Right, I didn't consider that.
>> .phy_pg_tbl = &rtw ## chip ## _bb_pg_type ## bb_pg ## _tbl, \
>> .txpwr_lmt_tbl = &rtw ## chip ## _txpwr_lmt_type ## pwrlmt ## _tbl, \
>> + .pwr_track_tbl = &rtw ## chip ## _pwr_track_type ## track ## _tbl, \
>> .agc_btg_tbl = &rtw ## chip ## _agc_btg_type ## btg ## _tbl, \
>> }
>>
>
