Mohammed Anees <pvmohammedanees2003@xxxxxxxxx> wrote: > Oops, I sent over the wrong patch with typo, > I'll make sure to fix that in the next version. > > > I feel compilers can optimize the check for the band, and we can just remove > > the else condition. Or > > if (2ghz) > > foo_2g(); > > else > > foo_5g(); > > I do agree with that but I feel, it would be > better to make it independent of compiler > optimization, thoughts? > > Let me know what you think is better, that is > whether letting it be if - else, or using a > pointer. Using a pointer looks delicate and optimized. The if-else code is simple to read. Since this chunk is small, I don't bias one of them. If I must choose one, I vote if-else.