On 15.10.24 11:13, Kalle Valo wrote:
Felix Fietkau <nbd@xxxxxxxx> writes:Sync iterator conditions with ieee80211_iter_keys_rcu. Fixes: 830af02f24fb ("mac80211: allow driver to iterate keys") Signed-off-by: Felix Fietkau <nbd@xxxxxxxx>I see this is already applied but why we need this? Please include a description of the bug in the commit message. That's too late now but if you provide one via email I can include it in the pull request.
I needed the key iterator for not yet published mt7996 work, and while reading the code found the inconsistency, that (unlike the RCU version) it could pass keys that weren't added to the driver yet. I didn't see any specific driver bugs, but the mac80211 code didn't make sense to me during review, so I fixed it.
- Felix
