On 08/10/2024 16:34, Zichen Xie wrote: > Hi, > > But Matthias suggested checking for NULL immediately after the declaration. Why do you keep top-posting? Matthias also asked you to stop, so that part you ignore? Responding to such HTML, top-post emails is a pain, so that is the last time I am writing here. I will be NAK-ing other totally bogus and untested patches, though. > Re: [PATCH v5] wifi: mt76: Fix NULL Dereference caused by > mt76_connac_get_he_phy_cap() - Matthias Brugger (kernel.org) > <https://lore.kernel.org/all/7daf8976-91ee-4045-a9a7-d9d14d53c6dd@xxxxxxxxx/> Don't send HTML. Anyway I do not see anything indicating that this should be before declarations. I see clearly: "before any use of struct vc." which is not before declarations. Best regards, Krzysztof
