Search Linux Wireless

Re: [PATCH v6 3/3] mac80211: implement dynamic power save

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 19, 2008 at 3:05 AM, Kalle Valo <kalle.valo@xxxxxxxxx> wrote:
> @@ -872,6 +878,9 @@ static void ieee80211_set_disassoc(struct ieee80211_sub_if_data *sdata,
>        local->oper_channel_type = NL80211_CHAN_NO_HT;
>        config_changed |= IEEE80211_CONF_CHANGE_HT;
>
> +       del_timer_sync(&local->dynamic_ps_timer);
> +       cancel_work_sync(&local->dynamic_ps_enable_work);

In addition, shouldn't we have this 'cancel_work'  in ieee80211_stop
or where ever in the stop/detach path since the ps timer may be
triggered even after the interface is brought down.

I need your thoughts on having null frame being sent from mac80211(
the RFC I submitted earlier).
Do you feel a state machine is necessary to go to power save? ( like
awake, sleep, pending_sleep if the AP hasn't acked the null frame with
a timer or a work queue to send null frame periodically in the pending
state). Or altogether you want that to be part of the driver and not
in mac80211?

Thanks,
Vivek.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux