Search Linux Wireless

Re: [PATCH 1/2] wifi: mwifiex: cleanup struct mwifiex_auto_tdls_peer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Dmitry,
thanks for your patch.

On Fri, Sep 27, 2024 at 11:43:16AM +0300, Dmitry Antipov wrote:
> Remove set but otherwise unused 'do_setup' member of
> 'struct mwifiex_auto_tdls_peer'. Compile tested only.
> 
> Fixes: 9927baa3c724 ("mwifiex: add auto TDLS support")
> Signed-off-by: Dmitry Antipov <dmantipov@xxxxxxxxx>

It looks like you are not having in Cc: the right people, please verify
your workflow.

In addition I do not think that such kind of patches should have a Fixes
tag. As you correctly wrote in the subject this is a clean-up, not a
fix.

I personally prefer to have a cover letter anytime you have more than 1
patch.

These applies to both the patches in this series.

Francesco





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux