Search Linux Wireless

Re: [PATCH v2] wifi: wilc1000: Keep slot powered on during suspend/resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/3/24 10:31 AM, Alexis Lothoré wrote:
On 9/29/24 17:23, Marek Vasut wrote:
On 9/28/24 1:18 PM, Kalle Valo wrote:
Marek Vasut <marex@xxxxxxx> writes:

The WILC3000 can suspend and enter low power state. According to local
measurements, the WILC3000 consumes the same amount of power if the slot
is powered up and WILC3000 is suspended, and if the WILC3000 is powered
off. Use the former option, keep the WILC3000 powered up as that allows
for things like WoWlan to work.

Note that this is tested on WILC3000 only, not on WILC1000 .

Signed-off-by: Marek Vasut <marex@xxxxxxx>
---
Cc: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx>
Cc: Alexis Lothoré <alexis.lothore@xxxxxxxxxxx>
Cc: Claudiu Beznea <claudiu.beznea@xxxxxxxxx>
Cc: Kalle Valo <kvalo@xxxxxxxxxx>
Cc: Marek Vasut <marex@xxxxxxx>
Cc: linux-wireless@xxxxxxxxxxxxxxx
---
V2: Rebase on next-20240926

BTW I recommend using wireless-next as the baseline for wireless
patches. For example, wireless-next is not pulled to linux-next during
merge windows or other patches in linux-next might create unnecessary
conflicts. Of course most of the cases using linux-next is fine.
I didn't know there was one such tree, added to remotes, thanks !

+1, as already mentioned in previous revisions, I would gladly test wilc3000
changes on both wilc3000 and wilc1000 on my platform, and having the series on
top of wireless-next would allow to do it on top of any change also affecting
the driver in wireless-next :)

I just had a look at a diff between wireless-next/main and next/master 20241003 for drivers/net/wireless/microchip , there are no changes to the driver between the two trees, so it should be possible to test this patch on either tree. Can you give it a try ? Ideally test this patch separately on WILC1000 across suspend/resume and check if it works. You might need the MMC controller fix which sets struct mmc_host .pm_caps |= MMC_PM_KEEP_POWER for your controller , unless this is already upstream.

The WILC3000 series depends on this patch.




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux