+ Johannes to comment wiphy_lock stuff petter@xxxxxxxxxx <petter@xxxxxxxxxx> wrote: > Hi, > > I have an issue with my 8822cu based usb device on >= 6.6 Linux with AP > mode. Using latest changes AP-mode seems to work fairly good. But when > enabling/disabling it I seems to always get below. It sometimes happens > without using AP-mode also, when for example disconnection happens due > to bad connection. Any ideas what might be causing this? Please also let > me know if you want additional debugging logs etc. > > BR Petter > > > ``` > > [ 1429.886683] WARNING: CPU: 0 PID: 9 at net/wireless/core.h:231 > disconnect_work+0xb8/0x144 [cfg80211] > [ 1429.898367] Modules linked in: rtw88_8822cu rtw88_8822c rtw88_usb > rtw88_core mac80211 libarc4 cfg80211 btusb btrtl btintel btbcm btmtk > imx_sdma ip_tables x_tables > [ 1429.913362] CPU: 0 PID: 9 Comm: kworker/0:1 Not tainted > 6.6.51-00141-ga1649b6f8ed6 #7 > [ 1429.921228] Hardware name: Freescale i.MX6 SoloX (Device Tree) > [ 1429.927082] Workqueue: events disconnect_work [cfg80211] > [ 1429.933556] unwind_backtrace from show_stack+0x10/0x14 > [ 1429.938833] show_stack from dump_stack_lvl+0x58/0x70 > [ 1429.943922] dump_stack_lvl from __warn+0x70/0x1c0 > [ 1429.948759] __warn from warn_slowpath_fmt+0x16c/0x294 > [ 1429.953939] warn_slowpath_fmt from disconnect_work+0xb8/0x144 > [cfg80211] > [ 1429.961935] disconnect_work [cfg80211] from I think the cause is picking commit 268f84a82753 ("wifi: cfg80211: check wiphy mutex is held for wdev mutex"), and cfg80211_is_all_idle() called by disconnect_work() uses wdev_lock() but not wiphy_lock(). I'm not sure if we should simply revert the picked commit 268f84a82753 or should pick more commits. By the way, I think the latest kernel will not throw these messages. Could you try it?