Search Linux Wireless

Re: [RFT v2 3/3] wifi: brcmfmac: cyw: support external SAE authentication in station mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arend,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 5a4d42c1688c88f3be6aef46b0ea6c32694cd2b8]

url:    https://github.com/intel-lab-lkp/linux/commits/Arend-van-Spriel/wifi-brcmfmac-support-per-vendor-cfg80211-callbacks-and-firmware-events/20240919-031359
base:   5a4d42c1688c88f3be6aef46b0ea6c32694cd2b8
patch link:    https://lore.kernel.org/r/20240918191109.41960-4-arend.vanspriel%40broadcom.com
patch subject: [RFT v2 3/3] wifi: brcmfmac: cyw: support external SAE authentication in station mode
config: i386-randconfig-r132-20240922 (https://download.01.org/0day-ci/archive/20240923/202409231704.8hLEAwe6-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240923/202409231704.8hLEAwe6-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409231704.8hLEAwe6-lkp@xxxxxxxxx/

sparse warnings: (new ones prefixed by >>)
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c:152:28: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] channel @@     got restricted __le32 [usertype] @@
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c:152:28: sparse:     expected restricted __le16 [usertype] channel
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c:152:28: sparse:     got restricted __le32 [usertype]
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c:159:9: sparse: sparse: cast to restricted __le32
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c:159:9: sparse: sparse: cast from restricted __le16
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c:217:9: sparse: sparse: incorrect type in argument 3 (different base types) @@     expected unsigned int @@     got restricted __le32 [addressable] [assigned] [usertype] ssid_len @@
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c:217:9: sparse:     expected unsigned int
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c:217:9: sparse:     got restricted __le32 [addressable] [assigned] [usertype] ssid_len
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c:254:33: sparse: sparse: cast to restricted __be32

vim +217 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c

   192	
   193	static int
   194	brcmf_cyw_external_auth(struct wiphy *wiphy, struct net_device *dev,
   195				struct cfg80211_external_auth_params *params)
   196	{
   197		struct brcmf_if *ifp;
   198		struct brcmf_pub *drvr;
   199		struct brcmf_auth_req_status_le auth_status;
   200		int ret = 0;
   201	
   202		brcmf_dbg(TRACE, "Enter\n");
   203	
   204		ifp = netdev_priv(dev);
   205		drvr = ifp->drvr;
   206		if (params->status == WLAN_STATUS_SUCCESS) {
   207			auth_status.flags = cpu_to_le16(BRCMF_EXTAUTH_SUCCESS);
   208		} else {
   209			bphy_err(drvr, "External authentication failed: status=%d\n",
   210				 params->status);
   211			auth_status.flags = cpu_to_le16(BRCMF_EXTAUTH_FAIL);
   212		}
   213	
   214		memcpy(auth_status.peer_mac, params->bssid, ETH_ALEN);
   215		auth_status.ssid_len = cpu_to_le32(min_t(u8, params->ssid.ssid_len,
   216							 IEEE80211_MAX_SSID_LEN));
 > 217		memcpy(auth_status.ssid, params->ssid.ssid, auth_status.ssid_len);
   218	
   219		ret = brcmf_fil_iovar_data_set(ifp, "auth_status", &auth_status,
   220					       sizeof(auth_status));
   221		if (ret < 0)
   222			bphy_err(drvr, "auth_status iovar failed: ret=%d\n", ret);
   223	
   224		return ret;
   225	}
   226	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux