On Thu, 2024-09-19 at 12:02 +0200, Nicolas Cavallari wrote:
>
> > Did I miss something ? Which one should we do ? I'm not sure of all the
> > implications of switching to the wiphy work queue and why it did not get
> > converted like the color_change_finalize_work stuff ?
>
> ieee80211_color_collision_detection_work() used to lock the wdev mutex, now it
> does not hold anything since 076fc8775da("wifi: cfg80211: remove wdev mutex")
>
> Also the rate limiting uses delayed_work_pending(), There is no wiphy work queue
> equivalent AFAIK, so the explicit lock is probably the way to go.
That won't work, it's cancel_delayed_work_sync() under the wiphy mutex,
so that'll cause deadlocks (and should cause lockdep complaints about
them.)
johannes
