On 9/18/2024 9:31 AM, kernel test robot wrote:
Hi Arend,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 34c44eb31de9cb7202ff070900463d6c706392c4]
url: https://github.com/intel-lab-lkp/linux/commits/Arend-van-Spriel/wifi-brcmfmac-support-per-vendor-cfg80211-callbacks-and-firmware-events/20240915-220310
base: 34c44eb31de9cb7202ff070900463d6c706392c4
patch link: https://lore.kernel.org/r/20240915140049.181380-4-arend.vanspriel%40broadcom.com
patch subject: [RFT 3/3] wifi: brcmfmac: cyw: support external SAE authentication in station mode
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240918/202409181714.QfWaGA1c-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240918/202409181714.QfWaGA1c-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409181714.QfWaGA1c-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c: In function 'brcmf_cyw_mgmt_tx':
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c:118:13: warning: variable 'timeout' set but not used [-Wunused-but-set-variable]
118 | s32 timeout;
| ^~~~~~~
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c: At top level:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c:52:42: warning: 'brcmf_cyw_event_map' defined but not used [-Wunused-const-variable=]
52 | static const struct brcmf_fweh_event_map brcmf_cyw_event_map = {
| ^~~~~~~~~~~~~~~~~~~
vim +/timeout +118 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c
51
> 52 static const struct brcmf_fweh_event_map brcmf_cyw_event_map = {
53 .items = {
54 { BRCMF_E_EXT_AUTH_REQ, BRCMF_CYW_E_EXT_AUTH_REQ },
55 { BRCMF_E_EXT_AUTH_FRAME_RX, BRCMF_CYW_E_EXT_AUTH_FRAME_RX },
56 { BRCMF_E_MGMT_FRAME_TXSTATUS, BRCMF_CYW_E_MGMT_FRAME_TXS },
57 {
58 BRCMF_E_MGMT_FRAME_OFFCHAN_DONE,
59 BRCMF_CYW_E_MGMT_FRAME_TXS_OC
60 },
61 },
62 .n_items = 1
Something definitely went wrong here or in my head :-(
63 };
64
[...]
101 static
102 int brcmf_cyw_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *wdev,
103 struct cfg80211_mgmt_tx_params *params, u64 *cookie)
104 {
105 struct brcmf_cfg80211_info *cfg = wiphy_to_cfg(wiphy);
106 struct ieee80211_channel *chan = params->chan;
107 struct brcmf_pub *drvr = cfg->pub;
108 const u8 *buf = params->buf;
109 size_t len = params->len;
110 const struct ieee80211_mgmt *mgmt;
111 struct brcmf_cfg80211_vif *vif;
112 s32 err = 0;
113 bool ack = false;
114 s32 chan_nr;
115 u32 freq;
116 struct brcmf_mf_params_le *mf_params;
117 u32 mf_params_len;
> 118 s32 timeout;
119
120 brcmf_dbg(TRACE, "Enter\n");
[...]
175 timeout =
176 wait_for_completion_timeout(&vif->mgmt_tx,
177 MGMT_AUTH_FRAME_WAIT_TIME);
Yep. Will fix it.
