Search Linux Wireless

Re: [PATCH] wifi: mwifiex: Fix memcpy() field-spanning write warning in mwifiex_config_scan()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Alper Nebi Yasak <alpernebiyasak@xxxxxxxxx>
Subject: Re: [PATCH] wifi: mwifiex: Fix memcpy() field-spanning write warning in mwifiex_config_scan()
From: Dmitry Antipov <dmantipov@xxxxxxxxx>
Date: Tue, 17 Sep 2024 20:01:00 +0300
Cc: linux-wireless@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, David Lin <yu-hao.lin@xxxxxxx>, Brian Norris <briannorris@xxxxxxxxxxxx>, Kalle Valo <kvalo@xxxxxxxxxx>, Francesco Dolcini <francesco@xxxxxxxxxx>, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>, Kees Cook <kees@xxxxxxxxxx>, "Gustavo A . R . Silva" <gustavoars@xxxxxxxxxx>, Johannes Berg <johannes.berg@xxxxxxxxx>, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
In-reply-to: <ZumuvP3aHiHHzGjp@smile.fi.intel.com>
References: <20240917150938.843879-1-alpernebiyasak@gmail.com> <ZumuvP3aHiHHzGjp@smile.fi.intel.com>
User-agent: Mozilla Thunderbird

On 9/17/24 7:30 PM, Andy Shevchenko wrote:

This hunk has to be carefully checked by wireless people. I'm not sure
that we need  + 1 here.


Well, +1 looks redundant here indeed.

And if you touch this anyway, please also consider '__counted_by(max_ssid_length)'
for 'ssid' (and test your kernel with CONFIG_KASAN enabled of course).

Dmitry

References:
- [PATCH] wifi: mwifiex: Fix memcpy() field-spanning write warning in mwifiex_config_scan()
  - From: Alper Nebi Yasak
- Re: [PATCH] wifi: mwifiex: Fix memcpy() field-spanning write warning in mwifiex_config_scan()
  - From: Andy Shevchenko

Prev by Date: Re: [PATCH] wifi: mwifiex: Fix memcpy() field-spanning write warning in mwifiex_config_scan()
Next by Date: Re: [PATCH] wifi: mwifiex: Fix memcpy() field-spanning write warning in mwifiex_config_scan()
Previous by thread: Re: [PATCH] wifi: mwifiex: Fix memcpy() field-spanning write warning in mwifiex_config_scan()
Next by thread: Re: [PATCH] wifi: mwifiex: Fix memcpy() field-spanning write warning in mwifiex_config_scan()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Host AP] [ATH6KL] [Linux Wireless Personal Area Network] [Linux Bluetooth] [Wireless Regulations] [Linux Netdev] [Kernel Newbies] [Linux Kernel] [IDE] [Git] [Netfilter] [Bugtraq] [Yosemite Hiking] [MIPS Linux] [ARM Linux] [Linux RAID]