On Fri, 2024-08-23 at 13:31 +0200, Felix Fietkau wrote: > > > On 23. Aug 2024, at 12:17, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > > > On Mon, 2024-08-05 at 21:23 +0200, Felix Fietkau wrote: > > > Radios are started/stopped based on the vif allowed radios. This allows > > > drivers to keep unused radios inactive. > > > > Similar argument here, I'd think you don't need this with > > WANT_MONITOR_VIF. Is this really something we want? Why? > > I want to keep radios shut down when no scan, roc or normal operation can happen on them (based on allowed radios mask). Makes sense I guess, but do you really need mac80211 helping with that? You already know which vifs are enabled and which aren't, and you can also access their radio mask if you want to. Not sure I see the added value of mac80211 keeping track of it. Worst case iterate the existing vifs when removing one? This is only needed/useful when there are multiple "real" devices and you don't have anything else managing them, so I kind of see this as a corner case, but perhaps I'm wrong? johannes
