Hello Marek, On 9/9/24 21:29, Marek Vasut wrote: > Export wilc_get_chipid() again and call it in driver probe to get > wilc->chipid assigned early on. This is necessary to discern WILC > 1000 from 3000 to disable WPA3/SAE on the later. I like the general change (reading chipid early enough so we can enable/disable NL80211_FEATURE_SAE accordingly before wiphy_register), but then there is no point in making wilc_get_chipid private in wlan.c in patch 2, to make it public to the module again in patch 7. Thanks, Alexis -- Alexis Lothoré, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
