> From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > Sent: Tuesday, September 10, 2024 3:22 PM > To: David Lin <yu-hao.lin@xxxxxxx> > Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > briannorris@xxxxxxxxxxxx; kvalo@xxxxxxxxxx; francesco@xxxxxxxxxx; Pete > Hsieh <tsung-hsien.hsieh@xxxxxxx> > Subject: Re: [EXT] Re: [PATCH v2] wifi: mwifiex: avoid AP and STA running on > different channel > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On Tue, Sep 10, 2024 at 06:18:57AM +0000, David Lin wrote: > > > > > > > With DRCS support enabled AP and STA actually can run on > > > > > > > different channels with the current code. You are breaking > > > > > > > this scenario with this > > > > > patch. > > > > > > > > > > > > > > Sascha > > > > > > > > > > > > > > > > > > > DRCS will be checked in the future. > > > > > > > > > > By future you mean v3 of this patch? > > > > > > > > > > Sascha > > > > > > > > > > > > > No schedule now. > > > > > > I am getting confused now. You want us to abandon my patch in favour > > > of yours, but you have no plans to update your patch to avoid a > > > regression that you introduce with your patch? > > > > > > Sascha > > > > > > > My patch resolves the same issue as your patch. But your patch can't > > let AP and STA run on the same channel if some wiphy parameters are > > set. > > > > I wonder did you test your patch? > > I finally see what you mean with "some wiphy parameters are set". > I did test my patch and I didn't run into this issue, because I haven't set > anything like rts_threshold in my config. > > Nevertheless what I am trying to tell you in this thread is: Your patch > introduces a regression and needs an update. > > It's not about my patch or your patch, both are currently not suitable for > inclusion and the question is: will you update your patch? > > Sascha > Without DRCS, this patch can avoid firmware crash and this is the current plan for Mwifiex. It won't affect any existing features. David
