On 9/4/24 13:18, Johannes Berg wrote:
On Wed, 2024-09-04 at 09:03 +0530, Aditya Kumar Singh wrote:
+ if (!chanctx_conf)
+ continue;
This changes the previous behaviour, is that OK?
As in? The only behavior change is previously, cac_cancel() will cancel
all CACs going on all sdata's. However, with MLO, if let's say link X on
MLD A detects radar, why link B on MLD Y should also cancel the radar?
I was just going by the fact that this didn't even care about the
chanctx conf before. It was just using the link_conf->chanreq.oper.
That's with patch 6, but before patch 6 it was just using
deflink.chanreq.oper and assuming you had a chanctx I think?
So I guess it's fine?
Yes, cause the comparison is now needed. Before MLO things were simpler.
The cast isn't needed. But you don't even really need the "itr_data"
variable since you never dereference it.
That's true but we are using it to compare it. If we don't type cast
then pointer comparison later would be problematic right?
No, why? It's void * so it's compatible with anything anyway. You don't
even need the cast for the assignment, why should you need one for a
comparison then?
okay yeah true that. Will remove. Thanks for the comments.
johannes
--
Aditya
