On Thu, Sep 5, 2024 at 2:33 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 05/09/2024 20:09, Rosen Penev wrote: > > These platform_data options are now available for OF. > > > > Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx> > > --- > > .../devicetree/bindings/net/wireless/qca,ath9k.yaml | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml > > index 0e5412cff2bc..5c293d558a94 100644 > > --- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml > > +++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml > > @@ -44,6 +44,16 @@ properties: > > > > ieee80211-freq-limit: true > > > > + qca,led-active-high: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + Indicates that the LED pin is active high instead of low > > + > > + qca,led-pin: > > So this all looks like re-inventing standard GPIOs, at least for devices > using GPIOLIB. Your commit msg needs proper rationale. git grep led_classdev_register drivers/net/wireless/ | wc -l 16 Both old and new drivers register their own GPIO devices to control LEDs. > > Best regards, > Krzysztof >
