On Wed, 2008-12-17 at 12:27 -0600, Larry Finger wrote: > Johannes, > > I'm trying to find a problem with p54usb that causes it to go belly-up under > stress testing. In one of my runs, I hit the WARN_ON in > ieee80211_tasklet_handler(). Unfortunately, I got no indication of what was in > skb->pkt_type, just that it was not one of the expected types. That really points to memory corruption somewhere. > Do you think that adding the printk below would be worthwhile? > > Thanks, > > Larry > --- > > Index: wireless-testing/net/mac80211/main.c > =================================================================== > --- wireless-testing.orig/net/mac80211/main.c > +++ wireless-testing/net/mac80211/main.c > @@ -341,6 +341,8 @@ static void ieee80211_tasklet_handler(un > dev_kfree_skb(skb); > break ; > default: > + printk(KERN_INFO "mac80211: Packet is of unknown type" > + " %d\n", skb->pkt_type); > WARN_ON(1); Seems reasonable to me. I'd do + WARN(1, "mac80211: ...", skb->pkt_type); - WARN_ON(1); instead. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
