On 9/4/2024 11:28 AM, Tomas Paukrt wrote: >> Also the Tested-on tag should include the firmware version information as well. > > Hi Jeff, > > I tested it with manually converted firmware from https://github.com/8devices/qcacld-2.0/tree/CNSS.LEA.NRT_3.0/firmware_bin/usb which does not include any explicit version. > > What version should I write in the Tested-on tag in this case? Ah, my good friend qcacld-2.0. I'd expect to see something written to kmsg, but not sure it is there for USB. for QMI there is: ath10k_info(ar, "qmi fw_version 0x%x fw_build_timestamp %s fw_build_id %s", qmi->fw_version, qmi->fw_build_timestamp, qmi->fw_build_id); but looking at past ath10k USB changes I only see: Tested-on: QCA9377 hw1.0 USB 1.0.0.299 So I guess what you have is OK since this just allows you to be probed anyway so that is actually independent of firmware version.
