On 9/4/2024 1:05 AM, Kalle Valo wrote: > Rosen Penev <rosenp@xxxxxxxxx> writes: > >> There are no more board files defining platform data for this driver and >> eeprom support through NVMEM has already been implemented. No need to >> keep this old functionality around. >> >> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx> >> --- >> As an aside, the last user of this functionality downstream in OpenWrt >> has been removed: https://github.com/openwrt/openwrt/commit/7ac8279bd >> >> drivers/net/wireless/ath/ath9k/eeprom.c | 12 ------------ >> 1 file changed, 12 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath9k/eeprom.c b/drivers/net/wireless/ath/ath9k/eeprom.c >> index efb7889142d4..df58dc02e104 100644 >> --- a/drivers/net/wireless/ath/ath9k/eeprom.c >> +++ b/drivers/net/wireless/ath/ath9k/eeprom.c >> @@ -15,7 +15,6 @@ >> */ >> >> #include "hw.h" >> -#include <linux/ath9k_platform.h> > > What about the file include/linux/ath9k_platform.h? That should be also > removed, right? That file is still used by other functionality (see init.c, btcoex.c) But seems that at a minimum unused eeprom-related stuff should be removed from struct ath9k_platform_data. Please review that all of the platform-related code in init.c is still needed, especially code related to eeprom support. /jeff
