On 04/09/2024 09:23, Raj Kumar Bhagat wrote: >>> + qcom,board_id: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + description: >>> + Board id value, it identifies the variant of ath12k WiFi device. >> >> Please do not upstream whatever you have in your vendor tree... You even >> copied its style! There is no such property in upstream. >> >> NAK, you are duplicating compatibles. >> >> > > qcom,board_id is a new parameter introduced to distinguish between different variants > of ath12k devices that share the same compatible value. This differentiation is crucial > as these variants have different qcom,board_id values (with the same compatible) based You must explain why compatible cannot be used for that. > on WiFi frequency bands capability. For example, 2 GHz, 5 GHz, 6 GHz, or multi-band > variants of ath12k devices have different qcom,board_id values. > > In the next version, I will include the above information in the qcom,board_id > description. Please follow DTS coding style. And style of existing properties like this. Did you look for them? I claim you just sent whatever you had in downstream. Best regards, Krzysztof
