+ Double Lo
On August 22, 2024 5:24:09 PM Marek Vasut <marex@xxxxxxx> wrote:
On 8/22/24 10:37 AM, Kalle Valo wrote:
Marek Vasut <marex@xxxxxxx> wrote:
From: Chung-Hsien Hsu <stanley.hsu@xxxxxxxxxxx>
Add support to download TRX firmware for PCIe and SDIO.
Signed-off-by: Chung-Hsien Hsu <chung-hsien.hsu@xxxxxxxxxxxx>
Signed-off-by: Marek Vasut <marex@xxxxxxx> # Upport to current linux-next
Please fix the review comments, also Ping's comment that from and s-o-b
needs to match.
I have most of the changes addressed locally already.
Regarding the SoB line, do I update the commit Author email (because
that would make more sense, cypress got assimilated into infineon) or
the SoB line email to the "old" cypress email address ?
I would say the SoB line is leading as developer's certificate and that has
the Infineon address so that seems more appropriate.
I am still hoping to get a bit more input on the TRX firmware handling
from Arend ... or maybe there is no further feedback ?
Took me a while before I looked into this. Can not offer much info though.
Within Broadcom code bases we only have a v1 and v2 defined for the TRX
format. This patch specifies v4. The only difference seem to be the number
of offsets and their meaning. Looking at the index definitions I suspect
this version accommodates signed firmware images which is verified by the
bootloader on the device.
Hopefully Infineon can/will confirm my suspicion and explain what SE in
.TRXSE stands for (security extension?). Anyways, this seem pretty specific
to (some) Infineon devices. Despite its history I would keep this separate
and specifically use trxse instead of trx.
Regards,
Arend
