Hi Nicolas, On Fri, Aug 30, 2024 at 10:19:42AM +0200, Nicolas Escande wrote: > Those two fields are used to store the per SPT page of tx/rx descriptors send to > the firmware for cookie conversion. Right now they are in struct ath12k_spt_info > which means they are duplicated PPT page times while we only need one instance > of them. This works for now as we always use the first spt_info as a global > storage for all PPT pages. > > Let's move them into struct ath12k_dp where they belong, alongside of the > spt_info array they are tied to, to avoid waisting a good bit of memory. > > Tested-on: QCN9274 hw2.0 PCI CI_WLAN.WBE.1.3-03283.1-QCAHKSWPL_SILICONZ-2 > > Signed-off-by: Nicolas Escande <nico.escande@xxxxxxxxx> Looks good to me. For what it worth: Reviewed-by: Remi Pommarel <repk@xxxxxxxxxxxx> -- Remi