On Wed, Aug 28, 2024 at 11:49:14AM +0800, Jacobe Zang wrote: > WiFi modules often require 32kHz clock to function. Add support to > enable the clock to PCIe driver and move "brcm,bcm4329-fmac" check > to the top of brcmf_of_probe. Change function prototypes from void > to int and add appropriate errno's for return values that will be > send to bus when error occurred. > > Co-developed-by: Ondrej Jirman <megi@xxxxxx> > Signed-off-by: Ondrej Jirman <megi@xxxxxx> > Co-developed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> > Signed-off-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> > Reviewed-by: Sai Krishna <saikrishnag@xxxxxxxxxxx> > Signed-off-by: Jacobe Zang <jacobe.zang@xxxxxxxxxx> ... > @@ -4452,7 +4454,9 @@ struct brcmf_sdio *brcmf_sdio_probe(struct brcmf_sdio_dev *sdiodev) > /* Allocate private bus interface state */ > bus = kzalloc(sizeof(*bus), GFP_ATOMIC); > if (!bus) > + ret = -ENOMEM; > goto fail; > + } > Perhaps a local change didn't make it into git, or something like that. But this does not compile. > bus->sdiodev = sdiodev; > sdiodev->bus = bus; ... -- pw-bot: cr