On 8/25/2024 6:49 PM, Baochen Qiang wrote: > Currently ath11k_dp_peer_cleanup() acquires ab->base_lock inside itself. This is > working because it is only called in below context where that lock is not held: > > ath11k_mac_op_sta_state() --> ath11k_mac_station_remove() > > In a upcoming patch that fixes memory leak in reset scenario, we need to do the > same job as ath11k_dp_peer_cleanup(). However ab->base_lock is already held there > so we can not directly call it. > > So the decision is to move lock/unlock outside of ath11k_dp_peer_cleanup() such > that we won't get deadlock in a context where the lock is already held. In order > to make sure it is called with lock held, add LOCKDEP assertion there. > > Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.30 > > Signed-off-by: Baochen Qiang <quic_bqiang@xxxxxxxxxxx> Acked-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>